trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1080: [TRAFODION-2603] Remove obsolete uti...
Date Tue, 02 May 2017 21:58:40 GMT
GitHub user DaveBirdsall opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/1080

    [TRAFODION-2603] Remove obsolete utilities and component privileges

    This set of changes does the following:
    
    1. Removes the PUBLISH and UNPUBLISH utility statements. They are from a predecessor product,
and do not work in Trafodion. And there is no specific requirement for them in Trafodion.
    
    2. Removes the INITIALIZE TRAFODION, CREATE SEQUENCE utility statement. Now that the SEQ_GEN
table is automatically created as part of the metadata schema, this utility is no longer needed.
    
    3. Changes GRANT COMPONENT PRIVILEGE to give an unsupported statement error (SQL code
-1010) if one of the DML_* privileges is given. They don't work, and there is consideration
being given to removing them.
    
    Note: If you upgrade your development instance to include this change, you may experience
a make failure complaining about the lack of file parser/StmtDDLPublish.h.
    
    The problem is that parser make dependency files still include a reference to this file.
"make clean" does not delete the dependency files. (Maybe it should!)
    
    To recover from this make failure, do the following:
    
    cd $TRAF_HOME/../sql/nskgmake/parser/linux/64bit/debug/depend
    
    rm *
    
    cd $TRAF_HOME/../sql/parser
    
    touch sqlparser.y
    
    These commands remove the make dependency files for the parser, and tell make to build
the parser file. When you next do a "make all", the dependency files will be regenerated.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaveBirdsall/incubator-trafodion RemoveOldUtils

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/1080.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1080
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message