trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1170: [TRAFODION-2628] SQL engine work for...
Date Mon, 17 Jul 2017 20:11:42 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1170#discussion_r127812127
  
    --- Diff: core/sql/optimizer/NAClusterInfo.cpp ---
    @@ -350,14 +244,8 @@ NAClusterInfo::NAClusterInfo(CollHeap * heap)
             if ((nodeInfo[i].type & MS_Mon_ZoneType_Aggregation) != 0 ||
    --- End diff --
    
    Yes, I would say we should look at the node type. Here is what I found in file core/sqf/export/include/seabed/ms.h:
    
        MS_Mon_ZoneType_Undefined   = 0x0000,   // No zone type defined
        MS_Mon_ZoneType_Edge        = 0x0001,   // Zone of service only nodes
        MS_Mon_ZoneType_Aggregation = 0x0002,   // Zone of compute only nodes
        MS_Mon_ZoneType_Storage     = 0x0004,   // Zone of storage only nodes
        MS_Mon_ZoneType_Excluded    = 0x0010,   // Excluded cores
    
    Maybe we should only look at nodes of type "MS_Mon_ZoneType_Aggregation", just like NAClusterInfo
does it? If you agree I can make that change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message