trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <>
Subject [GitHub] incubator-trafodion pull request #1192: [TRAFODION-2692] Fixed monitor start...
Date Tue, 01 Aug 2017 00:02:10 GMT
Github user DaveBirdsall commented on a diff in the pull request:
    --- Diff: core/sqf/monitor/linux/monitor.cxx ---
    @@ -1089,6 +1090,22 @@ int main (int argc, char *argv[])
    +    // Remove the domain portion of the name if any
    --- End diff --
    This is the third copy I've seen of code to remove the domain portion. Maybe they should
be refactored into a separate function?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message