trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1192: [TRAFODION-2692] Fixed monitor start...
Date Tue, 01 Aug 2017 00:02:10 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1192#discussion_r130491826
  
    --- Diff: core/sqf/monitor/linux/commaccept.cxx ---
    @@ -33,6 +33,7 @@ using namespace std;
     #include <signal.h>
     #include <unistd.h>
     
    +extern CCommAccept CommAccept;
    --- End diff --
    
    Global objects cause race conditions at exit time. Their destructors are called in non-deterministic
order. Does this object depend on any other objects? Does its destructor traverse to any other
objects? If so, then this will probably break at some time in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message