trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1192: [TRAFODION-2692] Fixed monitor start...
Date Tue, 01 Aug 2017 00:02:10 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1192#discussion_r130491389
  
    --- Diff: core/sqf/monitor/linux/clio.cxx ---
    @@ -377,6 +379,21 @@ Local_IO_To_Monitor::Local_IO_To_Monitor(int pv_pid)
             tmpptr++;
         }
     
    +    // Remove the domain portion of the name if any
    +    char str1[MPI_MAX_PROCESSOR_NAME];
    --- End diff --
    
    Is MPI_MAX_PROCESSOR_NAME the maximum name length? Or one more than the maximum name length?
If the former, then la_node_name, la_short_node_name and str1 should be declared as char[MPI_MAX_PROCESSOR_NAME+1]
to leave room for a trailing null. (The use of strcpy here made me think of that.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message