trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1174: [TRAFODION-2682] JVM startup options...
Date Wed, 12 Jul 2017 00:11:47 GMT
GitHub user zellerh opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/1174

    [TRAFODION-2682] JVM startup options like heap are not passed correctly

    Character arrays used to build the options went out of scope before
    they were passed to the JNI layer to create the JVM.
    
    Selva also requested that we use the default heap size defined in
    our code instead of the JVM default method of 1/4 the physical
    memory when a value <= 0 is passed in env var JVM_MAX_HEA_SIZE_MB.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zellerh/incubator-trafodion bug/2.2a

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/1174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1174
    
----
commit ca8146ecce9724b6cd3ff935e12c6cbbcade8df8
Author: Hans Zeller <hzeller@apache.org>
Date:   2017-07-12T00:09:21Z

    [TRAFODION-2682] JVM startup options like heap are not passed correctly
    
    Character arrays used to build the options went out of scope before
    they were passed to the JNI layer to create the JVM.
    
    Selva also requested that we use the default heap size defined in
    our code instead of the JVM default method of 1/4 the physical
    memory when a value <= 0 is passed in env var JVM_MAX_HEA_SIZE_MB.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message