trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1206: [TRAFODION-2617] Optionally push est...
Date Tue, 15 Aug 2017 21:56:44 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1206#discussion_r133314557
  
    --- Diff: core/sql/sqlcomp/nadefaults.cpp ---
    @@ -1759,6 +1763,7 @@ SDDkwd__(EXE_DIAGNOSTIC_EVENTS,		"OFF"),
      // exposure.
      DDkwd__(HBASE_DELETE_COSTING,		             "ON"),
      DDflt0_(HBASE_DOP_PARALLEL_SCANNER,             "0."),
    + DDkwd__(HBASE_ESTIMATE_ROW_COUNT_VIA_COPROCESSOR,   "OFF"),
    --- End diff --
    
    I like the co-processor approach because it encapsulates the HFile to region server code
and enables SQL to use well defined and externalized  APIs of HBase. From this perspective,
it should be good to remove the old estimate code entirely even with small performance penalty.
This would help to maintain the code better with future releases of hbase


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message