trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <>
Subject [GitHub] incubator-trafodion pull request #1213: implement isValid function
Date Thu, 24 Aug 2017 14:29:17 GMT
Github user selvaganesang commented on a diff in the pull request:
    --- Diff: core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/ ---
    @@ -1876,9 +1876,57 @@ public SQLXML createSQLXML() throws SQLException {
     		return null;
    -	public boolean isValid(int timeout) throws SQLException {
    -		// TODO Auto-generated method stub
    -		return false;
    +    public boolean isValid(int timeout) throws SQLException {
    +        if (props_.t4Logger_.isLoggable(Level.FINE) == true) {
    +            Object p[] = T4LoggingUtilities.makeParams(props_);
    +            props_.t4Logger_.logp(Level.FINE, "TrafT4Connection", "isValid", "iValid",
    +        }
    +        if (props_.getLogWriter() != null) {
    --- End diff --
    I meant to ask if the log will be written only when it is FINE. If so, you need to avoid
create all these objects in java and then throw it out while logging because the log level
is not set to FINE.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message