trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1207: [TRAFODION-2704]close unused statmen...
Date Thu, 31 Aug 2017 17:10:09 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1207#discussion_r136393387
  
    --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp ---
    @@ -6591,6 +6612,10 @@ odbc_SQLSrvr_UpdateLob_sme_(
             exception_->u.ParamError.ParamDesc = SQLSVC_EXCEPTION_EXECUTE_FAILED;
         }
     
    +    if (QryLobUpdateSrvrStmt != NULL) {
    +        QryLobUpdateSrvrStmt->Close(SQL_CLOSE);
    +    }
    +
    --- End diff --
    
    This doesn't really close the internal cursor statements that SQL maintains to retrieve
the LOB data. The JDBC driver has to issue a special syntax to close it. Once PR  https://github.com/apache/incubator-trafodion/pull/1216
 is merged in the special syntax needs to be issued to close the stream output ( SQL extract
) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message