trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xwq <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1225: [TRAFODION-2704]close unused statmen...
Date Tue, 12 Sep 2017 04:59:46 GMT
Github user xwq commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1225#discussion_r138251712
  
    --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp ---
    @@ -6489,6 +6506,31 @@ odbc_SQLSrvr_ExtractLob_sme_(
                     exception_->u.SQLError.errorList._buffer = QryLobExtractSrvrStmt->sqlError.errorList._buffer;
                     exception_->u.ParamError.ParamDesc = SQLSVC_EXCEPTION_EXECUTE_FAILED;
                 }
    +
    +            IDL_long_long zeroValue = 0;
    +            snprintf(LobExtractQuery, sizeof(LobExtractQuery), "EXTRACT LOBTOBUFFER(LOB'%s',
LOCATION %Ld, SIZE %Ld)", lobHandle, (Int64)lobDataValue, &zeroValue);
    +
    +            retcode = QryLobExtractSrvrStmt->ExecDirect(NULL, LobExtractQuery, EXTERNAL_STMT,
TYPE_CALL, SQL_ASYNC_ENABLE_OFF, 0);
    +
    --- End diff --
    
    I will documented it. 
    
    For the large data, they are some logic in JDBC need to be designed, I will add the code
when I have the solution.


---

Mime
View raw message