trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1225: [TRAFODION-2704]close unused statmen...
Date Tue, 12 Sep 2017 16:17:17 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1225#discussion_r138397172
  
    --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp ---
    @@ -6489,6 +6506,31 @@ odbc_SQLSrvr_ExtractLob_sme_(
                     exception_->u.SQLError.errorList._buffer = QryLobExtractSrvrStmt->sqlError.errorList._buffer;
                     exception_->u.ParamError.ParamDesc = SQLSVC_EXCEPTION_EXECUTE_FAILED;
                 }
    +
    +            IDL_long_long zeroValue = 0;
    +            snprintf(LobExtractQuery, sizeof(LobExtractQuery), "EXTRACT LOBTOBUFFER(LOB'%s',
LOCATION %Ld, SIZE %Ld)", lobHandle, (Int64)lobDataValue, &zeroValue);
    +
    +            retcode = QryLobExtractSrvrStmt->ExecDirect(NULL, LobExtractQuery, EXTERNAL_STMT,
TYPE_CALL, SQL_ASYNC_ENABLE_OFF, 0);
    +
    --- End diff --
    
    I am assuming that the streaming concept is implemented in the JDBC/ODBC driver and the
server side just fetches the data in bulk at some size, If the fetch bulk size is greater
than the user requested size, it would be serviced from the driver itself or when it is lesser
multiple chunks will be fetched to satisfy the user requested size. If so, this change looks
ok. However, there is a drawback that this change may not be portable to JDBC T2 driver because
there can be only one extract query active at a time.



---

Mime
View raw message