trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1225: [TRAFODION-2704]close unused statmen...
Date Tue, 12 Sep 2017 16:51:57 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1225#discussion_r138406464
  
    --- Diff: core/conn/odbc/src/odbc/nsksrvrcore/srvrothers.cpp ---
    @@ -6489,6 +6506,31 @@ odbc_SQLSrvr_ExtractLob_sme_(
                     exception_->u.SQLError.errorList._buffer = QryLobExtractSrvrStmt->sqlError.errorList._buffer;
                     exception_->u.ParamError.ParamDesc = SQLSVC_EXCEPTION_EXECUTE_FAILED;
                 }
    +
    +            IDL_long_long zeroValue = 0;
    +            snprintf(LobExtractQuery, sizeof(LobExtractQuery), "EXTRACT LOBTOBUFFER(LOB'%s',
LOCATION %Ld, SIZE %Ld)", lobHandle, (Int64)lobDataValue, &zeroValue);
    +
    +            retcode = QryLobExtractSrvrStmt->ExecDirect(NULL, LobExtractQuery, EXTERNAL_STMT,
TYPE_CALL, SQL_ASYNC_ENABLE_OFF, 0);
    +
    --- End diff --
    
    The multiple check extraction is not implemented yet according to Weiqing's previous comment
and it should be. Otherwise the application won't be able to  extract more than the first
 512 MB of data.That is our extract chunk size default in SQL.  But he will fix it in with
a different JIRA and PR.  


---

Mime
View raw message