trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1228: [TRAFODION-2733] Provide an improved...
Date Tue, 12 Sep 2017 18:04:55 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1228#discussion_r138409590
  
    --- Diff: core/sql/comexe/ComTdbSort.h ---
    @@ -201,11 +201,15 @@ class ComTdbSort : public ComTdb
       Int32 sortPartialKeyLen_;                             // 56-59
     
       UInt32 minimalSortRecs_;                              // 60-63
    -  Float32 sortMemEstInMbPerCpu_;                        // 64-67
    +  Float32 sortMemEstInKBPerNode_;                        // 64-67
       Float32 bmoCitizenshipFactor_;                        // 68-71
       Int32  pMemoryContingencyMB_;                        // 72-75
       UInt16 sortGrowthPercent_;                            // 76-77
    -  char fillersComTdbSort_[18];                          // 78-95
    +  char filler_1[2];                                     // 78-79
    +  Int32 topNThreshold_;                                 // 80-83
    +  Float32 estMemoryUsage_;                             // 84-87
    +  Float32 bmoQuotaRatio_;                              // 88-92
    --- End diff --
    
    Comment should be 88-91, and on the next line 92-95


---

Mime
View raw message