trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1228: [TRAFODION-2733] Provide an improved...
Date Tue, 12 Sep 2017 18:04:55 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1228#discussion_r138411375
  
    --- Diff: core/sql/executor/ex_exe_stmt_globals.h ---
    @@ -307,18 +307,38 @@ class ExExeStmtGlobals : public ex_globals
     
       inline NABoolean grabMemoryQuotaIfAvailable(ULng32 size)
       { 
    +    CliGlobals *cli_globals = GetCliGlobals();
    +    if (cli_globals->isEspProcess())
    +       return cli_globals->grabMemoryQuotaIfAvailable(size);
         if ( unusedBMOsMemoryQuota_ < size ) return FALSE;
         unusedBMOsMemoryQuota_ -= size ;
    --- End diff --
    
    I don't understand how this code relates to the code in cli/CliGlobals.cpp. There the
comments suggest that the memory quota is always stored in a context object. But here we seem
to be storing it in statement globals in the Master process case.


---

Mime
View raw message