trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1231: [Trafodion 2733] RMS semaphore handl...
Date Thu, 14 Sep 2017 00:47:43 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1231#discussion_r138773979
  
    --- Diff: core/sql/cli/Cli.cpp ---
    @@ -8325,19 +8325,15 @@ Lng32 SQLCLI_RegisterQuery(CliGlobals *cliGlobals,
       StatsGlobals *statsGlobals = cliGlobals->getStatsGlobals();
       if (statsGlobals == NULL)
         return retcode;
    -  short error;
    -  short savedPriority, savedStopMode;
    +  int error;
       error = statsGlobals->getStatsSemaphore(cliGlobals->getSemId(),
    -                 cliGlobals->myPin(), 
    -                savedPriority, savedStopMode, FALSE /*shouldTimeout*/);
    -  ex_assert(error == 0, "getStatsSemaphore() returned an error");
    -
    +                 cliGlobals->myPin());
    --- End diff --
    
    Why do we ignore the error?


---

Mime
View raw message