trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liuyu000 <>
Subject [GitHub] incubator-trafodion pull request #1229: [Trafodion-2734] Create *Trafodion L...
Date Thu, 14 Sep 2017 04:50:30 GMT
Github user liuyu000 commented on a diff in the pull request:
    --- Diff: docs/lob_guide/src/asciidoc/_chapters/work_with_lob.adoc ---
    @@ -0,0 +1,738 @@
    +* @@@ START COPYRIGHT @@@
    +* Licensed to the Apache Software Foundation (ASF) under one
    +* or more contributor license agreements. See the NOTICE file
    +* distributed with this work for additional information
    +* regarding copyright ownership. The ASF licenses this file
    +* to you under the Apache License, Version 2.0 (the
    +* "License"); you may not use this file except in compliance
    +* with the License. You may obtain a copy of the License at
    +* Unless required by applicable law or agreed to in writing,
    +* software distributed under the License is distributed on an
    +* KIND, either express or implied. See the License for the
    +* specific language governing permissions and limitations
    +* under the License.
    +* @@@ END COPYRIGHT @@@
    +[#work with lob]
    += Work with LOB
    --- End diff --
    Thanks Dave.
    Using gerund or verb (base) in title/headline is a style issue that should be followed
    Gerundive (continuous) form is common in title and verb form seems more imperative, but
given that 
    1. the topic title plays a huge role in the search results
    2. Trafodion has many users of non-native English speakers
    I think the verb form might be better as it more likely to match what people will search
for, and uses the more familiar form of the verb. 
    Any thoughts?


View raw message