trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1229: [TRAFODION-2734] Create *Trafodion L...
Date Mon, 18 Sep 2017 20:45:08 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1229#discussion_r139535246
  
    --- Diff: docs/lob_guide/src/asciidoc/_chapters/work_with_lob.adoc ---
    @@ -0,0 +1,738 @@
    +////
    +/**
    +* @@@ START COPYRIGHT @@@
    +*
    +* Licensed to the Apache Software Foundation (ASF) under one
    +* or more contributor license agreements. See the NOTICE file
    +* distributed with this work for additional information
    +* regarding copyright ownership. The ASF licenses this file
    +* to you under the Apache License, Version 2.0 (the
    +* "License"); you may not use this file except in compliance
    +* with the License. You may obtain a copy of the License at
    +*
    +*   http://www.apache.org/licenses/LICENSE-2.0
    +*
    +* Unless required by applicable law or agreed to in writing,
    +* software distributed under the License is distributed on an
    +* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +* KIND, either express or implied. See the License for the
    +* specific language governing permissions and limitations
    +* under the License.
    +*
    +* @@@ END COPYRIGHT @@@
    +*/
    +////
    +
    +[#work with lob]
    += Work with LOB
    --- End diff --
    
    It seems ungrammatical to my ear. An imperative tense would clearly not be correct. We
aren't telling the reader to "Work with LOBs!" (note the plural would be required, or alternatively
the indefinite article, "Work with a LOB!"). Rather we are trying to describe how one works
with LOBs. To me using the gerund seems most natural (in all cases, not just here); I would
recommend changing the style to do that. Another possibility is to use the infinitive, e.g.
"How to work with LOBs" (note again the plural). That might be more natural for English-as-a-second-language
users whose native language lacks gerund-like inflections.


---

Mime
View raw message