trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arvind-narain <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1240: [TRAFODION-2740]JDBC extract LOB con...
Date Thu, 21 Sep 2017 19:18:58 GMT
Github user arvind-narain commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1240#discussion_r140335560
  
    --- Diff: dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test/TestForeignKey.java
---
    @@ -74,12 +74,15 @@
     	public static void doTestSuiteSetup() throws Exception {
     		try{
     			_conn = DriverManager.getConnection(Utils.url, Utils.usr, Utils.pwd);
    -			Statement stmt = _conn.createStatement();
    -			
    -			stmt.execute(strCreatePKTABLE1Query);
    -			stmt.execute(strCreatePKTABLE2Query);
    -			stmt.execute(strCreateFKTABLE1Query);
    -			stmt.execute(strCreateFKTABLE2Query);
    +            try (
    --- End diff --
    
    Thanks for the change Weiqing. Learnt something new related to try-with-resource-statement
from your change - it does reduce the earlier code change planned - thanks.
    
    Could you please also take care of replacing DriverMagager.getConnection calls from *Blob*,
*Clob*, TestGetIndexInfo and this file ? This would take care random non-existent schema errors
seen.


---

Mime
View raw message