trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1241: [TRAFODION-2750] Using function strt...
Date Thu, 21 Sep 2017 20:34:44 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1241#discussion_r140351911
  
    --- Diff: core/conn/unixodbc/odbc/odbcclient/unixcli/cli/ctosqlconv.cpp ---
    @@ -3545,7 +3545,7 @@ unsigned long ODBC::ConvertCharToNumeric(SQLPOINTER srcDataPtr,
         rTrim(cTmpBuf);
         tempLen = strlen(cTmpBuf);
         errno = 0;
    -	dTmp = strtod(cTmpBuf, &errorCharPtr);
    +	dTmp = strtold(cTmpBuf, &errorCharPtr);
    --- End diff --
    
    Yeah, when I tried it I found on Red Hat Linux long double was 16 bytes. But on Windows
8, it is just 8 bytes. It depends on the platform. For what it is worth, I found that the
implicit cast from long double to double worked fine on both platforms.


---

Mime
View raw message