trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sandhyasun <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1240: [TRAFODION-2740]JDBC extract LOB con...
Date Fri, 22 Sep 2017 18:42:23 GMT
Github user sandhyasun commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1240#discussion_r140568181
  
    --- Diff: dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test/TestForeignKey.java
---
    @@ -74,12 +74,15 @@
     	public static void doTestSuiteSetup() throws Exception {
     		try{
     			_conn = DriverManager.getConnection(Utils.url, Utils.usr, Utils.pwd);
    -			Statement stmt = _conn.createStatement();
    -			
    -			stmt.execute(strCreatePKTABLE1Query);
    -			stmt.execute(strCreatePKTABLE2Query);
    -			stmt.execute(strCreateFKTABLE1Query);
    -			stmt.execute(strCreateFKTABLE2Query);
    +            try (
    --- End diff --
    
    I see you did a new commit to fix some review comments. Can you also fix this one ? This
fix is needed for the daily builds to pass. We often get "non existent schema " errrors with
JDBC tests.


---

Mime
View raw message