trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1248: [trafodion-2728] - bug fix - SHOWSTA...
Date Thu, 28 Sep 2017 20:43:13 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1248#discussion_r141730360
  
    --- Diff: core/sql/ustat/hs_globals.cpp ---
    @@ -8472,6 +8472,23 @@ Lng32 HSGlobalsClass::groupListFromTable(HSColGroupStruct*&
groupList,
     
         // Initialize the pointer to the group list we will build.
         groupList = NULL;
    +    
    +    // if showstats for a native hbase table, need to check if the schema _HBASESTATS_
exist
    +    if (strcmp(hstogram_table->data(), "TRAFODION.\"_HBASESTATS_\".SB_HISTOGRAMS")
== 0)
    --- End diff --
    
    Are there any other examples of this kind of bug besides native HBase access? What happens
if we do SHOWSTATS on a native Hive table, for example, but the "_HIVESTATS_" schema has not
yet been created? (This kind of question is why I was hoping for a solution where we interpreted
the error code from cursor103.open() instead.)


---

Mime
View raw message