trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anoopsharma00 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1226: TRAFODION-2731 CodeCleanup: Remove o...
Date Wed, 06 Sep 2017 18:22:22 GMT
GitHub user anoopsharma00 opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/1226

    TRAFODION-2731 CodeCleanup: Remove obsolete, legacy and unused code

    This phase handles the following:
    
    -- removal of code that dealt with:
       -- mpalias, NSK, MP, mploc, resource fork, rfork
       -- ARLIB, DISK, VOLUME, PFS, compiler version info
       -- interpretasrow/IAR, AuditImage, ExtractColumns functions
       -- ARKCMP_SINGLE_PROCESS and oneProcess()
       -- recompControl, remoteDefaults, rtdu,  module
       -- latebind thru nsk defines, guardian names, nametype nsk
       -- SHADOW implementation
       -- MEASURE
       -- older sqlcat ReadTableDef
       -- DP2_MEMORY, DP2_SPACE, HGB_DP2_MEMORY_LIMIT
       -- internal cli methods no longer used by any caller
    
    Code within the following defines is removed if it is obsolete
    or the define itself is removed if that feature is always on:
       -- removed NA_EIDPROC
       -- removed SQLEXP_LIB_FUNC
       -- removed NA_CMPDLL
       -- removed SQ_PHANDLE_VERIFIER
       -- removed SQ_NEW_PHANDLE
       -- removed __EID
       -- removed ARKFS_OPEN
       -- removed STAND_ALONE
       -- removed  __TANDEM
       -- removed NA_C89
       -- removed NA_NSK
       -- removed SQLEXPORT_LIB_FUNC
       -- removed SQLCLI_LIB_FUNC
       -- removed CLI_PRIV_SRL
       -- removed PRIV_SRL
       -- removed NA_LINUX
       -- removed NA_HSC_LINUX
       -- removed NA_UNIX
       -- removed NA_WINNT
       -- removed HAVE_MMAP
       -- removed NA_NO_C_RUNTIME
       -- removed NA_DEBUG_C_RUNTIME(replaced with _DEBUG)
       -- removed NA_64BIT usage except in sqlcli.h
       -- removed dg64
       -- removed SQLEXPORT_LIB
       -- removed NA_ARKFS
       -- removed NA_IEEE_FLOAT
       -- removed NA_GUARDIAN_MSG
       -- removed NA_HSC
       -- removed NA_TMFNOTYETSUPPORTED
       -- removed ERROR
       -- removed ERROR_STATE
       -- removed SQLERRORS_LIB_FUNC
    
    Contents of these files have been removed.
    Next checkin fill remove the files itself from git:
      executor/dmeasql.h
      executor/ExMeas.h, ExMeas.cpp
      executor/tempfile.h, .cpp
      executor/rcb.h
      executor/stubs.cpp, stubs2.cpp
      exp/srlversion.cpp
      cli/rtdu.h, rtdu2.h, rtdu.cpp, rtdu.cpp
      cli/VicKeyValuePair.h
      cli/CliDll.cpp
      cli/CliStubsStaticBuild.cpp
      cli/globalsrlversion.cpp
      cli/globalstubs.cpp
      cli/sqlciSRLStubs.cpp
      cli/test.cpp
      cli/privsrlversion.cpp
      common/SqlExpDllDefines.h
      common/SqlExportDllDefines.h
      sqlcat/enum.h
      sqlcat/ReadTableDef.h, cpp
      sqlcat/readRealArk.h, cpp

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anoopsharma00/incubator-trafodion ansharma_trafr23_deliver

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/1226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1226
    
----
commit 1522c8cd0e33859c0671606364183f31d0d3902f
Author: Anoop Sharma <anoop.sharma@esgyn.com>
Date:   2017-09-06T18:20:09Z

    TRAFODION-2731 CodeCleanup: Remove obsolete, legacy and unused code
    
    This phase handles the following:
    
    -- removal of code that dealt with:
       -- mpalias, NSK, MP, mploc, resource fork, rfork
       -- ARLIB, DISK, VOLUME, PFS, compiler version info
       -- interpretasrow/IAR, AuditImage, ExtractColumns functions
       -- ARKCMP_SINGLE_PROCESS and oneProcess()
       -- recompControl, remoteDefaults, rtdu,  module
       -- latebind thru nsk defines, guardian names, nametype nsk
       -- SHADOW implementation
       -- MEASURE
       -- older sqlcat ReadTableDef
       -- DP2_MEMORY, DP2_SPACE, HGB_DP2_MEMORY_LIMIT
       -- internal cli methods no longer used by any caller
    
    Code within the following defines is removed if it is obsolete
    or the define itself is removed if that feature is always on:
       -- removed NA_EIDPROC
       -- removed SQLEXP_LIB_FUNC
       -- removed NA_CMPDLL
       -- removed SQ_PHANDLE_VERIFIER
       -- removed SQ_NEW_PHANDLE
       -- removed __EID
       -- removed ARKFS_OPEN
       -- removed STAND_ALONE
       -- removed  __TANDEM
       -- removed NA_C89
       -- removed NA_NSK
       -- removed SQLEXPORT_LIB_FUNC
       -- removed SQLCLI_LIB_FUNC
       -- removed CLI_PRIV_SRL
       -- removed PRIV_SRL
       -- removed NA_LINUX
       -- removed NA_HSC_LINUX
       -- removed NA_UNIX
       -- removed NA_WINNT
       -- removed HAVE_MMAP
       -- removed NA_NO_C_RUNTIME
       -- removed NA_DEBUG_C_RUNTIME(replaced with _DEBUG)
       -- removed NA_64BIT usage except in sqlcli.h
       -- removed dg64
       -- removed SQLEXPORT_LIB
       -- removed NA_ARKFS
       -- removed NA_IEEE_FLOAT
       -- removed NA_GUARDIAN_MSG
       -- removed NA_HSC
       -- removed NA_TMFNOTYETSUPPORTED
       -- removed ERROR
       -- removed ERROR_STATE
       -- removed SQLERRORS_LIB_FUNC
    
    Contents of these files have been removed.
    Next checkin fill remove the files itself from git:
      executor/dmeasql.h
      executor/ExMeas.h, ExMeas.cpp
      executor/tempfile.h, .cpp
      executor/rcb.h
      executor/stubs.cpp, stubs2.cpp
      exp/srlversion.cpp
      cli/rtdu.h, rtdu2.h, rtdu.cpp, rtdu.cpp
      cli/VicKeyValuePair.h
      cli/CliDll.cpp
      cli/CliStubsStaticBuild.cpp
      cli/globalsrlversion.cpp
      cli/globalstubs.cpp
      cli/sqlciSRLStubs.cpp
      cli/test.cpp
      cli/privsrlversion.cpp
      common/SqlExpDllDefines.h
      common/SqlExportDllDefines.h
      sqlcat/enum.h
      sqlcat/ReadTableDef.h, cpp
      sqlcat/readRealArk.h, cpp

----


---

Mime
View raw message