trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertamarton <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1288: New COMMENT-ON SQL statement
Date Thu, 02 Nov 2017 20:45:18 GMT
Github user robertamarton commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1288#discussion_r148654557
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLtable.cpp ---
    @@ -12940,6 +12940,142 @@ TrafDesc *CmpSeabaseDDL::getSeabaseRoutineDescInternal(const
NAString &catName,
     }
     
     
    +short CmpSeabaseDDL::getSeabaseObjectComment(Int64 object_uid, 
    --- End diff --
    
    Should this be part of CmpSeabaseDDLcommentOn.cpp?  This keeps all comment related code
in the same file.


---

Mime
View raw message