trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1295: [TRAFODION-2794] Add *DIVISION BY (C...
Date Mon, 13 Nov 2017 22:20:33 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1295#discussion_r150683181
  
    --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
    @@ -3308,6 +3343,43 @@ SELECT * FROM T WHERE b = 'A';
     SELECT * FROM T WHERE b = 'A' (not casespecific);
     ```
     
    +* This is the 1^st^ example of DIVISION BY usage.
    ++
    +```
    +CREATE TABLE call_home_data
    +(id LARGEINT NOT NULL,
    +ts TIMESTAMP(6) NOT NULL,
    +device_status VARCHAR(200),
    +PRIMARY KEY (id, ts))
    +SALT USING 16 PARTITIONS ON (id)
    +DIVISION BY (date_trunc('day', ts));
    +```
    +
    +* This is the 2^nd^ example of DIVISION BY usage.
    ++
    +```
    +CREATE TABLE sales1
    +(store_id INT NOT NULL,
    +item_id  INT NOT NULL,
    +sale_date DATE DEFAULT DATE '2000-01-01' NOT NULL,
    +sale_amt NUMERIC(10,2),
    +PRIMARY KEY (store_id, item_id, sale_date))
    +DIVISION BY (DATEDIFF(YEAR, '2017-11-02', sale_date));
    +```
    +
    +* This is the 3^rd^ example of DIVISION BY usage.
    --- End diff --
    
    Consider spelling out "third". By the way, many style guides suggest spelling out the
ordinals "first", "second", ... "tenth", then using the abbreviated form 11^th^ and so on
for larger numbers.


---

Mime
View raw message