trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1288: New COMMENT-ON SQL statement
Date Mon, 13 Nov 2017 23:14:18 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150693272
  
    --- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
    @@ -3777,6 +3826,76 @@ short CmpDescribeSeabaseTable (
             }
         }
     
    +  //display comments
    +  if (type == 2 && objectUID > 0)
    +    {
    +      enum ComObjectType objType = COM_BASE_TABLE_OBJECT;
    +
    +      if (isView)
    +        {
    +          objType = COM_VIEW_OBJECT;
    +        }
    +
    +      if (cmpSBD.switchCompiler())
    +        {
    +          *CmpCommon::diags() << DgSqlCode(-CAT_UNABLE_TO_RETRIEVE_COMMENTS);
    +          return -1;
    +        }
    + 
    +      ComTdbVirtObjCommentInfo objCommentInfo;
    +      if (cmpSBD.getSeabaseObjectComment(objectUID, objType, objCommentInfo, heap))
    +        {
    +          *CmpCommon::diags() << DgSqlCode(-CAT_UNABLE_TO_RETRIEVE_COMMENTS);
    +          return -1;
    --- End diff --
    
    Should we switch back compiler if we go through this error path?


---

Mime
View raw message