trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1288: New COMMENT-ON SQL statement
Date Mon, 13 Nov 2017 23:14:18 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150694388
  
    --- Diff: core/sql/sqlcomp/CmpSeabaseDDLschema.cpp ---
    @@ -445,14 +445,39 @@ Int16 status = ComUser::getAuthNameFromAuthID(objectOwner,username,
        output += catalogName.data();
        output += "\".\"";
        output += schemaName.data();
    -   
    +
     // AUTHORIZATION clause is rarely used, but include it for replay.
        output += "\" AUTHORIZATION \"";
        output += username;
        output += "\";";
        
        outlines.push_back(output.data());
     
    +   // Display Comment of schema
    +    {
    +      ComTdbVirtObjCommentInfo objCommentInfo;
    +      if (cmpSBD.getSeabaseObjectComment(schemaUID, objectType, objCommentInfo, STMTHEAP))
    +        {
    +          *CmpCommon::diags() << DgSqlCode(-CAT_UNABLE_TO_RETRIEVE_COMMENTS);
    +          return -1;
    --- End diff --
    
    Switch back compiler here?


---

Mime
View raw message