trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1288: New COMMENT-ON SQL statement
Date Mon, 13 Nov 2017 23:14:18 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150693110
  
    --- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
    @@ -3059,6 +3061,54 @@ short CmpDescribeSeabaseTable (
     
           outputLongLine(*space, viewtext, 0);
     
    +      //display comment for VIEW
    +      if (objectUID > 0)
    +        {
    +          if (cmpSBD.switchCompiler())
    +            {
    +              *CmpCommon::diags() << DgSqlCode(-CAT_UNABLE_TO_RETRIEVE_COMMENTS);
    +              return -1;
    +            }
    +
    +          ComTdbVirtObjCommentInfo objCommentInfo;
    +          if (cmpSBD.getSeabaseObjectComment(objectUID, COM_VIEW_OBJECT, objCommentInfo,
heap))
    +            {
    +              *CmpCommon::diags() << DgSqlCode(-CAT_UNABLE_TO_RETRIEVE_COMMENTS);
    +              return -1;
    --- End diff --
    
    Should we switch the compiler back when going through this error path?


---

Mime
View raw message