trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1288: New COMMENT-ON SQL statement
Date Mon, 13 Nov 2017 23:14:18 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150693464
  
    --- Diff: core/sql/sqlcomp/CmpDescribe.cpp ---
    @@ -4129,6 +4280,37 @@ char buf[1000];
            ((CmpCommon::getDefault(SHOWDDL_DISPLAY_PRIVILEGE_GRANTS) == DF_SYSTEM)
                && getenv("SQLMX_REGRESS"))) ? FALSE : TRUE;
     
    +//display library comment
    +   if (libraryUID > 0)
    +   {
    +     if (cmpSBD.switchCompiler())
    +       {
    +         *CmpCommon::diags() << DgSqlCode(-CAT_UNABLE_TO_RETRIEVE_PRIVS);
    +         return -1;
    +       }
    +
    +     ComTdbVirtObjCommentInfo objCommentInfo;
    +     if (cmpSBD.getSeabaseObjectComment(libraryUID, COM_LIBRARY_OBJECT, objCommentInfo,
heap))
    +       {
    +         *CmpCommon::diags() << DgSqlCode(-CAT_UNABLE_TO_RETRIEVE_COMMENTS);
    +         return -1;
    --- End diff --
    
    Switch back compiler here?


---

Mime
View raw message