trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1288: New COMMENT-ON SQL statement
Date Mon, 13 Nov 2017 23:14:19 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150691328
  
    --- Diff: core/sql/parser/StmtDDLCommentOn.h ---
    @@ -0,0 +1,153 @@
    +/**********************************************************************
    +// @@@ START COPYRIGHT @@@
    +//
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +//
    +// @@@ END COPYRIGHT @@@
    +**********************************************************************/
    +#ifndef STMTDDLCOMMENTON_H
    +#define STMTDDLCOMMENTON_H
    +/* -*-C++-*-
    + *****************************************************************************
    + *
    + * File:         StmtDDLCommentOn.h
    + * Description:  class for Comment On Statement (parser node)
    + *
    + *
    + * Created:      8/2/17
    + * Language:     C++
    + *
    + *
    + *
    + *
    + *****************************************************************************
    + */
    +
    +#include "ComSmallDefs.h"
    +#include "StmtDDLNode.h"
    +
    +
    +
    +// -----------------------------------------------------------------------
    +// forward references
    +// -----------------------------------------------------------------------
    +// None
    +
    +// -----------------------------------------------------------------------
    +// Comment On statement
    +// -----------------------------------------------------------------------
    +class StmtDDLCommentOn : public StmtDDLNode
    +{
    +  
    +public:
    +
    +  enum COMMENT_ON_TYPES {
    +    COMMENT_ON_TYPE_TABLE = 10,
    --- End diff --
    
    I am curious: why do we start at 10? Is there another enum that this one has to co-exist
with? If so, would be good to mention that in a comment here (in case the other enum expands
some day).


---

Mime
View raw message