trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From EEDY <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1288: New COMMENT-ON SQL statement
Date Tue, 14 Nov 2017 05:14:58 GMT
Github user EEDY commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150739440
  
    --- Diff: core/sql/common/ComSmallDefs.h ---
    @@ -660,7 +662,9 @@ enum ComTextType {COM_VIEW_TEXT = 0,
                       COM_HBASE_COL_FAMILY_TEXT = 5,
                       COM_HBASE_SPLIT_TEXT = 6,
                       COM_STORED_DESC_TEXT = 7,
    -                  COM_VIEW_REF_COLS_TEXT = 8
    +                  COM_VIEW_REF_COLS_TEXT = 8,
    +                  COM_OBJET_COMMENT_TEXT = COM_TABLE_COMMENT_TEXT,
    --- End diff --
    
    Yes, it should be COM_OBJECT_COMMENT_TEXT.


---

Mime
View raw message