trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From EEDY <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1288: New COMMENT-ON SQL statement
Date Tue, 14 Nov 2017 05:15:28 GMT
Github user EEDY commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150739473
  
    --- Diff: core/sql/parser/sqlparser.y ---
    @@ -33167,7 +33173,106 @@ stats_merge_clause : /*empty */
                    { $$ = SQLCLI_PROGRESS_STATS; }
                  | TOK_DEFAULT
                    { $$ = SQLCLI_SAME_STATS; }  
    -                   
    +
    +
    +/* type pStmtDDL */
    +comment_on_statement : TOK_COMMENT TOK_ON comment_on_object_types ddl_qualified_name
TOK_IS QUOTED_STRING
    +               {
    +                 StmtDDLCommentOn *pNode = 
    +                   new(PARSERHEAP()) StmtDDLCommentOn(
    +                     $3,
    +                     *$4,
    +                     *$6,
    +                     PARSERHEAP()
    +                   );
    +
    +                 $$ = pNode;
    +               }
    +             | TOK_COMMENT TOK_ON TOK_SCHEMA schema_name TOK_IS QUOTED_STRING
    +               {
    +                 // EJF L4J - CQD dynamic are not allowed in Compound Statements
    --- End diff --
    
    No, i do not want to disallow COMMENT ON within a compound statement.
    I will remove this comment and if branch.


---

Mime
View raw message