trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liuyu000 <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1309: [TRAFODION-2815] Add/Update Syntax, ...
Date Thu, 23 Nov 2017 02:20:28 GMT
Github user liuyu000 commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1309#discussion_r152715017
  
    --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc
---
    @@ -2297,19 +2297,22 @@ DATEADD(DAY, 7, timestamp'2008-02-29 00:00:00')
     == DATEDIFF Function
     
     The DATEDIFF function returns the integer value for the number of
    -_datepart_ units of time between _startdate_ and _enddate_. If
    -_enddate_ precedes _startdate_, the return value is negative or zero.
    +_datepart_ units of time between _startdate_ and _enddate_. 
     
     DATEDIFF is a {project-name} SQL extension.
     
     ```
     DATEDIFF (datepart, startdate, enddate)
     ```
     
    +<<<
    +[[syntax_description_of_datediff]]
    +=== Syntax Description of DATEDIFF 
    +
     * `datepart`
     +
     is YEAR, MONTH, DAY, HOUR, MINUTE, SECOND, QUARTER, WEEK, or one of the
    -following abbreviations:
    +following abbreviations, should be enclosed in quotation marks:
    --- End diff --
    
    Thanks Dave, for pointing out this mistake, I've corrected. :)



---

Mime
View raw message