trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From duoluodexiaokeke <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1307: [TRAFODION-2791] 'Not casespecific' ...
Date Tue, 28 Nov 2017 06:37:36 GMT
Github user duoluodexiaokeke commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1307#discussion_r153405510
  
    --- Diff: core/sql/optimizer/ItemColRef.h ---
    @@ -350,6 +350,14 @@ class ConstValue : public ItemExpr
                NAMemory * outHeap = CmpCommon::statementHeap()
             );
     
    +  ConstValue(const NAString& strval,
    +           NABoolean isCaseInSensitive,
    +           enum CharInfo::CharSet charSet=CharInfo::DefaultCharSet,
    +           enum CharInfo::Collation collation=CharInfo::DefaultCollation,
    +           enum CharInfo::Coercibility coercibility=CharInfo::COERCIBLE,
    +           NAMemory * outHeap = CmpCommon::statementHeap()
    +        );
    --- End diff --
    
    first, I think isCaseInSensitive is a import attribute,
    second, i don't think add this argument to the end of constructor is a good way.
    if add this argument in the second position, it will change some code where call it.
    so i add a new constructor.


---

Mime
View raw message