trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From duoluodexiaokeke <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1307: [TRAFODION-2791] 'Not casespecific' ...
Date Tue, 28 Nov 2017 07:46:48 GMT
Github user duoluodexiaokeke commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1307#discussion_r153414282
  
    --- Diff: core/sql/optimizer/OptRange.cpp ---
    @@ -503,7 +503,13 @@ ConstValue* OptRangeSpec::getConstOperand(ItemExpr* predExpr, Lng32
constInx)
       // currently support. Predicates involving types not yet supported will be
       // treated as residual predicates.
       if (QRDescGenerator::typeSupported(static_cast<ConstValue*>(right)->getType()))
    +  {
    --- End diff --
    
    I do those operators in order to add case-insensitive to new constvalue.
    i don't understand the a
    for b, case-insensitive only use in 
                 if (parentOfStart)
                    parentOfStart->child(1) =
                        new(mvqrHeap_) ConstValue(charSubrange->start,
     if add a RangeSpec methods about case-insensitive , we need add this attribute to parentOfStart->child(1)
after operating above.
    so i don't think this is a good way


---

Mime
View raw message