trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zellerh <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1307: [TRAFODION-2791] 'Not casespecific' ...
Date Tue, 28 Nov 2017 17:11:06 GMT
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1307#discussion_r153560323
  
    --- Diff: core/sql/optimizer/OptRange.cpp ---
    @@ -503,7 +503,13 @@ ConstValue* OptRangeSpec::getConstOperand(ItemExpr* predExpr, Lng32
constInx)
       // currently support. Predicates involving types not yet supported will be
       // treated as residual predicates.
       if (QRDescGenerator::typeSupported(static_cast<ConstValue*>(right)->getType()))
    +  {
    --- End diff --
    
    RangeSpecs keep a list of points and intervals and these intervals need to be ordered,
otherwise RangeSpec doesn't work. If we have case-insensitive comparison, that ordering needs
to be different, but as far as I could tell, there is no code at the moment that would do
a case-insensitive ordering of the values.


---

Mime
View raw message