trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1314: [TRAFODION-2821] Trafodion core code...
Date Tue, 28 Nov 2017 17:33:08 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1314#discussion_r153564680
  
    --- Diff: core/sql/executor/OrcFileReader.cpp ---
    @@ -111,9 +133,15 @@ OFR_RetCode OrcFileReader::init()
     //    JavaMethods_[JM_FETCHBUFF2].jm_signature = "(II)[Ljava/lang/String;";
         JavaMethods_[JM_CLOSE     ].jm_name      = "close";
         JavaMethods_[JM_CLOSE     ].jm_signature = "()Ljava/lang/String;";
    -   
    -    return (OFR_RetCode)JavaObjectInterface::init(className, javaClass_, JavaMethods_,
(Int32)JM_LAST, FALSE);
    +    
    +    lv_retcode = (OFR_RetCode)JavaObjectInterface::init(className,
    +							javaClass_,
    +							JavaMethods_,
    +							(Int32)JM_LAST, javaMethodsInitialized_);
    +    javaMethodsInitialized_ = TRUE;
    --- End diff --
    
    Nit. This should be "true" instead of "TRUE" since this is a bool instead of an NABoolean.
But it's an unobservable bug.


---

Mime
View raw message