trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1314: [TRAFODION-2821] Trafodion core code...
Date Tue, 28 Nov 2017 17:33:10 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1314#discussion_r153566118
  
    --- Diff: core/sql/executor/SequenceFileReader.cpp ---
    @@ -189,9 +192,10 @@ SFR_RetCode SequenceFileReader::open(const char* path)
       if (jresult != NULL)
       {
         logError(CAT_SQL_HDFS_SEQ_FILE_READER, "SequenceFileReader::open()", jresult);
    +    jenv_->PopLocalFrame(NULL);
    --- End diff --
    
    The DeleteLocalRef at line 190 is no longer needed, but harmless, right?


---

Mime
View raw message