trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1314: [TRAFODION-2821] Trafodion core code...
Date Tue, 28 Nov 2017 21:23:19 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1314#discussion_r153627095
  
    --- Diff: core/sql/executor/OrcFileReader.cpp ---
    @@ -122,24 +150,28 @@ OFR_RetCode OrcFileReader::init()
     OFR_RetCode OrcFileReader::open(const char* path)
     {
       QRLogger::log(CAT_SQL_HDFS_ORC_FILE_READER, LL_DEBUG, "OrcFileReader::open(%s) called.",
path);
    +
    +  if (initJNIEnv() != JOI_OK)
    +     return OFR_ERROR_OPEN_PARAM;
       jstring js_path = jenv_->NewStringUTF(path);
       if (js_path == NULL) 
    +  {
    +    jenv_->PopLocalFrame(NULL);
    --- End diff --
    
    Thanks.


---

Mime
View raw message