trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From selvaganesang <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1310: [TRAFODION-2816] ODBC data convert f...
Date Wed, 29 Nov 2017 16:10:30 GMT
Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1310#discussion_r153831339
  
    --- Diff: core/conn/unixodbc/odbc/odbcclient/unixcli/cli/drvrglobal.cpp ---
    @@ -1092,6 +1092,106 @@ bool ctoi64(char* string, __int64& out, bool* truncation)
     	free (buff);
     	return true;
     }
    +unsigned __int64 _atoui64( const char *s )
    +{
    +	unsigned __int64 n = 0;
    +	char* t = (char*)s;
    +	char c;
    +
    +	while(*t != 0)
    +	{
    +		c = *t++;
    +		if (c < '0' || c > '9') continue;
    --- End diff --
    
    Does this mean the junk characters are tolerated when the string is converted to numeric
column? If so, this can lead to unexpected behavior.


---

Mime
View raw message