trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] incubator-trafodion pull request #1317: JIRA TRAFODION-2731 CodeCleanup: Pha...
Date Thu, 30 Nov 2017 01:15:24 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/1317#discussion_r153962765
  
    --- Diff: core/sql/sqlcomp/nadefaults.cpp ---
    @@ -523,20 +520,14 @@ SDDkwd__(CAT_ENABLE_QUERY_INVALIDATION, "ON"),
     
      // Throw an error if a column is part of the store by clause and
      // is not defined as NOT NULL return an error
    - DDkwd__(CAT_ERROR_ON_NOTNULL_STOREBY, "ON"),
     
    - DDui1__(CAT_FS_TIMEOUT,                       "9000"),
     
      // Used to make ignore "already exists" error in Create and
      // "does not exist" error in Drop.
    --- End diff --
    
    Comment should be deleted too.


---

Mime
View raw message