trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1399: [TRAFODION-2909] Add ROLLUP Function for *Traf...
Date Wed, 17 Jan 2018 22:09:40 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1399#discussion_r162192522
  
    --- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_functions_and_expressions.adoc
---
    @@ -6337,6 +6337,300 @@ UPDATE persnl.job
     SET jobdesc = RIGHT (jobdesc, 12);
     ```
     
    +<<<
    +[[rollup_function]]
    +== ROLLUP Function
    +
    +The ROLLUP function calculates multiple levels of subtotals aggregating from right to
left through the comma-separated list of columns, and provides a grand total. It is a an extension
to the `GROUP BY` clause and can be used with `ORDER BY` to sort the results.
    --- End diff --
    
    There is no "ORDER BY ROLLUP" syntax. But it looks like there are functions such as GROUPING
that can refer to whether a column is used as a grouping column in a rollup result row, so
one can order the detail vs. the summary rows. There's also a small typo here "...is a an..."
Possible wordsmith for the last sentence: "It is an extension to the 'GROUP BY' clause. Related
features such as the GROUPING function can be used with 'ORDER BY' to control the placement
of summary results."


---

Mime
View raw message