trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From SuJinpei <...@git.apache.org>
Subject [GitHub] trafodion pull request #1404: Trafodion 2916
Date Thu, 18 Jan 2018 12:32:58 GMT
GitHub user SuJinpei opened a pull request:

    https://github.com/apache/trafodion/pull/1404

    Trafodion 2916

    **the root cause**:  the allocating size of str is determined by max field length + 128(here
is 1500+128), but during loading, str will be filled with actual field data exceeding this
size(here maybe 2000 characters) if str overflow the client app will crash. 
    **solution**: increase the size of str to the size of one-time fread(default is 262144).
there is still a risk of a crash when a user provides an incredibly large size of an invalid
field.
    **additional fix**: also fix other same type potential bugs in Oload2 and OloadJason.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SuJinpei/incubator-trafodion trafodion-2916

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafodion/pull/1404.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1404
    
----
commit dd231aaf95094400a59d4f99521d76a8771b625a
Author: SuJinpei <873118042@...>
Date:   2018-01-18T11:43:46Z

    fix TRAFODION-2916

commit 44a05e0793f27ec1b76e515c8441bd3605bbb090
Author: SuJinpei <873118042@...>
Date:   2018-01-18T11:59:50Z

    remove debug code

----


---

Mime
View raw message