trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] trafodion pull request #1433: [TRAFODION-2939] odb copied data exceeds the m...
Date Fri, 02 Feb 2018 00:01:47 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1433#discussion_r165525730
  
    --- Diff: core/conn/odb/src/odb.c ---
    @@ -5491,9 +5491,11 @@ static void etabadd(char type, char *run, int id)
                         }
                     } else {                            /* not a load job */
                         etab[no].k = no;                /* record grandparent for copy/diff
ops */
    -                    if ( etab[no].ps ){
    +                    if ( etab[no].ps > 1 ){
    --- End diff --
    
    Can you please explain why we don't need this IF block when etab[no].ps  =1 ? Is it it
because for a extract/copy when we have one stream comparing rowset size to max number of
rows is done elsewhere in this file?


---

Mime
View raw message