trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1437: [TRAFODION-2650] Reorganized Trafodion Configu...
Date Mon, 05 Feb 2018 22:09:50 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1437#discussion_r166126270
  
    --- Diff: core/sqf/sqenvcom.sh ---
    @@ -47,6 +47,15 @@ export PRODUCT_COPYRIGHT_HEADER="2015-2017 Apache Software Foundation"
     ##############################################################
     export TRAFODION_ENABLE_AUTHENTICATION=${TRAFODION_ENABLE_AUTHENTICATION:-NO}
     
    +# Set the Trafodion Configuration store type
    +if [[ -n "$CLUSTERNAME" ]]; then
    +  # This is a cluster environment, not a workstation
    +  #export TRAF_CONFIG_DBSTORE=MySQL
    +  export TRAF_CONFIG_DBSTORE=Sqlite
    +else
    +  export TRAF_CONFIG_DBSTORE=Sqlite
    --- End diff --
    
    Looks like it is aways Sqlite. Why bother with the "if"? Earlier I saw mention in the
code that Sqlite is deprecated. Is that still the case?


---

Mime
View raw message