trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1428: [TRAFODION-2874] New syntax to retrieve the LO...
Date Tue, 06 Feb 2018 19:46:03 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1428#discussion_r166419614
  
    --- Diff: core/sql/cli/Cli.cpp ---
    @@ -9160,11 +9160,45 @@ Lng32 SQLCLI_LOBcliInterface
     
     	Int64 outlen = 0;Lng32 len = 0;
     	cliRC = cliInterface->executeImmediate(query,(char *)dataLen, &len, FALSE);
    -	    if (inoutDescPartnKey)
    -	      *inoutDescPartnKey = descPartnKey;
    +        if (inoutDescPartnKey)
    +          *inoutDescPartnKey = descPartnKey;
     
    -	    if (inoutDescSyskey)
    -	      *inoutDescSyskey = inDescSyskey;
    +        if (inoutDescSyskey)
    +          *inoutDescSyskey = inDescSyskey;
    +	    
    +	Lng32 saveCliErr = cliRC;
    +
    +	
    +	if (cliRC < 0)
    +	  {
    +	    cliInterface->retrieveSQLDiagnostics(myDiags);
    +	    
    +	    goto error_return;
    +	  }
    +
    +	cliRC = saveCliErr;
    +      }
    +      break;
    +     case LOB_CLI_SELECT_LOBOFFSET:
    +      {
    +	
    +	//Retrive offset of the first chunk
    +	str_sprintf(query, "select  c.dataOffset from table(ghost table %s) h, table(ghost table
%s) c where h.descPartnKey = c.descPartnKey and h.syskey = c.descSyskey and h.descPartnKey
= %ld and h.syskey = %ld and c.chunkNum = 1 for read committed access",
    +		    lobDescHandleName, lobDescChunksName, 
    +		    descPartnKey, inDescSyskey);
    +
    +        lobDebugInfo(query,0,__LINE__,lobTrace);
    +	// set parserflags to allow ghost table
    +	currContext.setSqlParserFlags(0x1);
    --- End diff --
    
    Is there code somewhere to revert the parser flags setting?


---

Mime
View raw message