trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1428: [TRAFODION-2874] New syntax to retrieve the LO...
Date Tue, 06 Feb 2018 19:46:04 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1428#discussion_r166420852
  
    --- Diff: core/sql/exp/ExpLOBaccess.cpp ---
    @@ -870,6 +870,67 @@ Ex_Lob_Error ExLob::getLength(char *handleIn, Int32 handleInLen,Int64
&outLobLen
           }
       return err;
     }
    +Ex_Lob_Error ExLob::getOffset(char *handleIn, Int32 handleInLen,Int64 &outLobOffset,LobsSubOper
so, Int64 transId)
    +{
    +  char logBuf[4096];
    +  Int32 cliErr = 0;
    +  Ex_Lob_Error err=LOB_OPER_OK; 
    +  char *blackBox = new(getLobGlobalHeap()) char[MAX_LOB_FILE_NAME_LEN+6];
    --- End diff --
    
    It doesn't look like this is used anywhere. Maybe we can delete this?


---

Mime
View raw message