trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...
Date Mon, 12 Feb 2018 04:29:37 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1417#discussion_r167457124
  
    --- Diff: core/sql/executor/ExHdfsScan.cpp ---
    @@ -1149,8 +1297,12 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
     	        if (hdfsScanTdb().continueOnError())
     	        {
     	          if ((pentry_down->downState.request == ex_queue::GET_N) &&
    -	              (pentry_down->downState.requestValue == matches_))
    -	            step_ = CLOSE_FILE;
    +	              (pentry_down->downState.requestValue == matches_)) {
    +                     if (useLibhdfsScan_)
    +                        step_ = CLOSE_HDFS_CURSOR;
    --- End diff --
    
    Is this intentional, to change from CLOSE_FILE to CLOSE_HDFS_CURSOR?


---

Mime
View raw message