trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sureshsubbiah <...@git.apache.org>
Subject [GitHub] trafodion pull request #1417: [TRAFODION-2917] Refactor Trafodion implementa...
Date Mon, 12 Feb 2018 04:29:37 GMT
Github user sureshsubbiah commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1417#discussion_r167464350
  
    --- Diff: core/sql/generator/GenRelScan.cpp ---
    @@ -1391,6 +1391,9 @@ if (hTabStats->isOrcFile())
       hdfsscan_tdb->setUseCif(useCIF);
       hdfsscan_tdb->setUseCifDefrag(useCIFDegrag);
     
    +  if (CmpCommon::getDefault(USE_LIBHDFS_SCAN) == DF_ON)
    --- End diff --
    
    Should we add a check that says if a table has any file that is compressed then we will
not disable libhdfs scan? Or maybe support for compressed files is coming soon and for now
we set this cqd OFF only if we thing conditions warrant it?


---

Mime
View raw message