trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From traflm <...@git.apache.org>
Subject [GitHub] trafodion pull request #1444: [TRAFODION-2954] add MySQL function unix_times...
Date Wed, 21 Feb 2018 01:19:22 GMT
Github user traflm commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1444#discussion_r169511829
  
    --- Diff: core/sql/optimizer/GroupAttr.cpp ---
    @@ -1793,6 +1793,8 @@ void GroupAttributes::resolveCharacteristicInputs(const ValueIdSet&
externalInpu
     	     ItemExpr * vidExpr = vid.getItemExpr();
     	     if ((vidExpr->getOperatorType() == ITM_CURRENT_USER) ||
     		 (vidExpr->getOperatorType() == ITM_CURRENT_TIMESTAMP) ||
    +		 (vidExpr->getOperatorType() == ITM_UNIQUE_SHORT_ID) ||
    +		 (vidExpr->getOperatorType() == ITM_UNIQUE_ID) ||
    --- End diff --
    
    You are right, Hans, I also think in the opposite, I just simply follow the current_timestamp
behavior, and this really is not what I originally want. So I will change uuid() to be evaluated
once per row. 


---

Mime
View raw message