trafodion-codereview mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaveBirdsall <...@git.apache.org>
Subject [GitHub] trafodion pull request #1451: [TRAFODION-2965] Fix row count stats for parti...
Date Wed, 21 Feb 2018 18:28:20 GMT
Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1451#discussion_r169733349
  
    --- Diff: core/sql/executor/ex_hash_grby.cpp ---
    @@ -1027,8 +1027,10 @@ void ex_hash_grby_tcb::returnResultCurrentRow(HashRow * dataPointer)
       upParentEntry->upState.downIndex = parentQueue_.down->getHeadIndex();
       
       // if stats are to be collected, collect them.
    -  if (bmoStats_)
    -    bmoStats_->incActualRowsReturned();
    +  ExOperStats *statsEntry = getStatsEntry();
    --- End diff --
    
    Is the member bmoStats_ no longer used then? Should it be deleted?


---

Mime
View raw message